Tuesday 5 April 2016

I won't make big pull requests (repeat 500 times)

Lately we are getting some pull requests through into ManageIQ, and some people has come to ask me some questions...

What size should a pull request have?

Possible answers:
  1. Complete functionality (i.e. that big awesome pull request that creates a new chargeback, fixed the world and praises God at the same time)
  2. Independent functionality (i.e. that big pull request that needs others)
  3. Something that works (i.e. complete feature but only part of a use case)
  4. A small pull request (i.e. nothing works here but it is fine)

Choose wisely.....